Skip to content

Conversation

@joerunde
Copy link
Collaborator

Description

Adds a small table to the docs with the suggested version of pytorch to use for a given version of torch_sendnn

@joerunde joerunde requested a review from rafvasq as a code owner October 14, 2025 20:19
@github-actions
Copy link

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

@jberkhahn
Copy link
Collaborator

LGTM

Copy link
Collaborator

@rafvasq rafvasq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of nits for conciseness/consistency with the rest of the doc

Finally, `torch` is needed to run examples and tests. If it is not already installed,
install it using `pip`.

The spyre runtime stack only supports a narrow range of torch versions. The suggested torch versions to use for a given version of torch_sendnn are:
Copy link
Collaborator

@rafvasq rafvasq Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The spyre runtime stack only supports a narrow range of torch versions. The suggested torch versions to use for a given version of torch_sendnn are:
The Spyre runtime stack supports specific `torch` versions. Use the compatible version for each `torch_sendnn` release:


The spyre runtime stack only supports a narrow range of torch versions. The suggested torch versions to use for a given version of torch_sendnn are:

| torch_sendnn | pytorch |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| torch_sendnn | pytorch |
| torch_sendnn | torch |

Copy link
Collaborator

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Rafael Vasquez <[email protected]>
Signed-off-by: Joe Runde <[email protected]>
@joerunde joerunde merged commit 9360445 into main Oct 17, 2025
18 checks passed
@joerunde joerunde deleted the doc-torch-version branch October 17, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants