-
Notifications
You must be signed in to change notification settings - Fork 26
📝 add supported torch versions #528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Joe Runde <[email protected]>
|
👋 Hi! Thank you for contributing to vLLM support on Spyre. Or this can be done with Now you are good to go 🚀 |
|
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of nits for conciseness/consistency with the rest of the doc
docs/getting_started/installation.md
Outdated
| Finally, `torch` is needed to run examples and tests. If it is not already installed, | ||
| install it using `pip`. | ||
|
|
||
| The spyre runtime stack only supports a narrow range of torch versions. The suggested torch versions to use for a given version of torch_sendnn are: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The spyre runtime stack only supports a narrow range of torch versions. The suggested torch versions to use for a given version of torch_sendnn are: | |
| The Spyre runtime stack supports specific `torch` versions. Use the compatible version for each `torch_sendnn` release: |
docs/getting_started/installation.md
Outdated
|
|
||
| The spyre runtime stack only supports a narrow range of torch versions. The suggested torch versions to use for a given version of torch_sendnn are: | ||
|
|
||
| | torch_sendnn | pytorch | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| | torch_sendnn | pytorch | | |
| | torch_sendnn | torch | |
Signed-off-by: Joe Runde <[email protected]>
c8f39b1 to
734c7ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Rafael Vasquez <[email protected]> Signed-off-by: Joe Runde <[email protected]>
Description
Adds a small table to the docs with the suggested version of pytorch to use for a given version of torch_sendnn